[BUGFIX lts-2-8] Fix JSHint issue with referencing Symbol.#14531
Merged
rwjblue merged 1 commit intoemberjs:releasefrom Oct 27, 2016
Merged
[BUGFIX lts-2-8] Fix JSHint issue with referencing Symbol.#14531rwjblue merged 1 commit intoemberjs:releasefrom
Symbol.#14531rwjblue merged 1 commit intoemberjs:releasefrom
Conversation
The guard for using `Symbol` should not have been setup this way (`let Symbol = Symbol || null` will never be defined AFAICT since the transpilation would use `var` which hoists). Either way, there is no need for the local `Symbol` variable since we can just check if it is defined as the guard.
This was referenced Oct 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard for using
Symbolshould not have been setup this way (let Symbol = Symbol || nullwill never be defined AFAICT since thetranspilation would use
varwhich hoists).Either way, there is no need for the local
Symbolvariable since wecan just check if it is defined as the guard.