[BUGFIX] use strict mode for Object.create

[givanse]

Cleaning up the changes from #9442

Bug 138038 - [iOS8][ARMv7(s)] Optimized Object.create in 'use strict' context sometimes breaks.
https://bugs.webkit.org/show_bug.cgi?id=138038

2015-07-06
This was fixed in iOS 9 Dev Seed 2.

[stefanpenner]

wooo nice. We will need to merge this, IFF the % of affected users is very low. Although I hope we can land this now.

[givanse]

Market share as measured by the App Store on October 25, 2016.

iOS 10 - 60%
iOS 9 - 32%
earlier - 8%

This other site says: iOS 8 (3.59%)

And this one says: iOS 8 (3.3%)

[stefanpenner]

@givanse thanks for those stats.

[stefanpenner]

We still don't know how many of those users are on 32bit devices (the affected devices). It may be quite abit smaller then?

[rwjblue]

@stefanpenner - Ya, agreed. Should be at least somewhat smaller, and if this rides the typical canary cycle it will be another 8-10 weeks more before release.

This seems good to me...

[rwjblue]

Added to meeting agenda for 2016-12-02 (no meeting on 2016-11-25 due to Thanksgiving in the US).

[givanse]

From list of iOS devices, the ones with ARMv7 are the iPhone 5 and iPhone 5C.

Device usage:
iPhone 5 4.9%
iPhone 5c 2.9%

iPhone 8.X adoption:
iPhone 5 7.1%
iPhone 5c 3.1%

Affected users:
iPhone 5 (4.9%/100 * 7.1%/100) * 100 = 0.3479%
iPhone 5c (2.9%/100 * 3.1%/100) * 100 = 0.0899%

total = 0.4378%

Plus, Christmas is coming and people will be getting new shinny mobiles XD

[rwjblue]

Awesome, thanks for digging in on these stats (they make this much more actionable)!

[givanse]

I would have done it with the PR submission, TIL webkit bugs have tags & ARMv7 is a x32 architecture :)

[stefanpenner]

@givanse big +1 on doing the digging on this one. you rock

[aleige1993]

For beginners, passing by

[homu]

☔ The latest upstream changes (presumably #14649) made this pull request unmergeable. Please resolve the merge conflicts.

[stefanpenner]

Pinged the core-team, hoping to get a resolution this week.

My opinion is that, based on @givanse numbers provided (and that the existing fix is somewhat somewhat precarious) we should let this ride the canary train.

[givanse]

forgot about this and push -f to master in my fork, sorry about that XD