[WIP] Deprecate component lifecycle hook arguments#14711
Merged
chancancode merged 3 commits intomasterfrom Jan 9, 2017
Merged
Conversation
Contributor
|
☔ The latest upstream changes (presumably #14756) made this pull request unmergeable. Please resolve the merge conflicts. |
locks
force-pushed
the
deprecate-component-lifecycle-hook-args
branch
3 times, most recently
from
9cbe967 to
fec4f59
Compare
locks
force-pushed
the
deprecate-component-lifecycle-hook-args
branch
from
3a96921 to
3752909
Compare
locks
force-pushed
the
deprecate-component-lifecycle-hook-args
branch
from
bdf7a07 to
1089fd3
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually changes the arguments a little bit (there is always
{ attrs, oldAttrs, newAttrs }now – see the changed tests), but since we are deprecating it and removing it soon after, it seems fine to me.