[FEATURE ember-factory-for] Remove duplicated code.#14736
Merged
Conversation
chadhietala
reviewed
Dec 19, 2016
| } | ||
| }); | ||
|
|
||
| if (isFeatureEnabled('ember-factory-for')) { |
Contributor
There was a problem hiding this comment.
The isFeatureEnabled import needs to be removed.
Member
Author
There was a problem hiding this comment.
Ahh, thank you! Will update
rwjblue
force-pushed
the
rwjblue-patch-1
branch
from
f6102c9 to
e29ca62
Compare
This functionality was moved into `ContainerProxyMixin`, and doesn't need to be duplicated here.
rwjblue
force-pushed
the
rwjblue-patch-1
branch
from
e29ca62 to
1515b84
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality was moved into
ContainerProxyMixin, and doesn't need to be duplicated here.