Add unit tests for ember-glimmer/utils/iterable#14763
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jan 23, 2017
Merged
Conversation
pittst3r
force-pushed
the
iterable-tests
branch
from
554cb2f to
8d0f9d5
Compare
pittst3r
force-pushed
the
iterable-tests
branch
from
8d0f9d5 to
30cf11a
Compare
locks
approved these changes
Jan 13, 2017
Member
|
Awesome, thank you! |
Member
|
@robbiepitts we are in the process of moving Ember to Glimmer VM master and these tests are failing because they rely on internals that doesn't exists anymore ( |
29 tasks
Contributor
Author
|
@chancancode I don't like deleting tests without good reason (I don't see one in this case?). I will investigate porting them. |
Member
|
For now I have removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #14725 I noticed there were no unit tests for this file, so I added them. Looks like the issue has since been resolved though.