Skip to content

Remove internal factoryInjection API#14816

Closed
locks wants to merge 3 commits intomasterfrom
skull-emoji-factory-injection
Closed

Remove internal factoryInjection API#14816
locks wants to merge 3 commits intomasterfrom
skull-emoji-factory-injection

Conversation

@locks
Copy link
Contributor

@locks locks commented Jan 11, 2017 •
edited
Loading

  • Container: A factory returned from lookupFactory has a debugkey
  • Ember.Application Dependency Injection – toString: instances
  • Ember.Application Dependency Injection – toString: with a custom resolver

@locks locks force-pushed the skull-emoji-factory-injection branch from 9e40ee1 to 7041640 Compare January 12, 2017 13:42
@locks
Remove _factoryInjections and _factoryTypeInjections dictionaries
d69f8d3 
Remove factoryInjections related code
Kill lookupFactory debugkey test
Add NAME_KEY to injectedFactory class
@locks locks force-pushed the skull-emoji-factory-injection branch from 275739b to d69f8d3 Compare January 12, 2017 15:03
@locks locks requested a review from dgeb January 13, 2017 15:47
rwjblue
rwjblue reviewed Jan 20, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with all of this work, but I'd really like to see us remove that last reopenClass in deprecatedFactoryFor. Though maybe it isn't worth a ton of effort since we plan to remove that whole chunk of code with the ember-factory-for feature flag...

packages/container/lib/container.js Outdated
// TODO - remove all `container` injections when Ember reaches v3.0.0
injectDeprecatedContainer(injectedFactory.prototype, container);
injectedFactory.reopenClass(factoryInjections);
injectedFactory.reopenClass({ [NAME_KEY]: registry.makeToString(factory, fullName) });
Copy link
Member

@rwjblue rwjblue Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we can get rid of this also (I'm not sure we have solved the "problem" of factory injections if we cannot remove this reopenClass).

@homu
Copy link
Contributor

homu commented Mar 14, 2017

☔ The latest upstream changes (presumably #15014) made this pull request unmergeable. Please resolve the merge conflicts.

@stefanpenner
Copy link
Member

stefanpenner commented Mar 14, 2017

@locks ping

@stefanpenner
Copy link
Member

stefanpenner commented Mar 16, 2017 •
edited
Loading

@locks nice, I think this may be a bugfix beta? @rwjblue c/d

@locks
Copy link
Contributor Author

locks commented Mar 16, 2017

@stefanpenner there was a problem with 5b2dc4d that I don't know how to address. I think it particularly broke some of Ember Data's output.

@homu
Copy link
Contributor

homu commented Apr 27, 2017

☔ The latest upstream changes (presumably #15177) made this pull request unmergeable. Please resolve the merge conflicts.

@stefanpenner
Copy link
Member

stefanpenner commented Apr 27, 2017

@stefanpenner there was a problem with 5b2dc4d that I don't know how to address. I think it particularly broke some of Ember Data's output.

@locks can you enumerate the problem, steps to reproduce?

@rwjblue
Copy link
Member

rwjblue commented Apr 30, 2017

I believe this will be replaced by #15193.

@locks locks closed this Apr 30, 2017
@locks locks deleted the skull-emoji-factory-injection branch April 30, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwjblue rwjblue rwjblue left review comments

@dgeb dgeb Awaiting requested review from dgeb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@locks @homu @stefanpenner @rwjblue