add test verifying that registering an unknown service raises an exception

[GavinJoyce]

This now passes, but didn't in Ember 2.10. I git bisected the test and it passes since #14360

[rwjblue]

Should use expectAssertion here (otherwise it will fail for prod builds).

[GavinJoyce]

this seems to be an Error, not an assertion:

ember.js/packages/container/lib/registry.js

Line 712 in aeeddf7

throw new Error(`Attempting to inject an unknown injection: '${fullName}'`);

Should this be an assertion?

[rwjblue]

That validateInjections method is only called from here:

ember.js/packages/container/lib/container.js

Lines 505 to 513 in 9b3d581

	runInDebug(() => {
	// Ensure that all lazy injections are valid at instantiation time
	if (!validationCache[fullName] && typeof factory._lazyInjections === 'function') {
	lazyInjections = factory._lazyInjections();
	lazyInjections = container.registry.normalizeInjectionsHash(lazyInjections);
	container.registry.validateInjections(lazyInjections);
	}
	});

Which is inside of a runInDebug...

[GavinJoyce]

thanks

[GavinJoyce]

It's also called from here, which doesn't seem to be wrapped in a runInDebug:

ember.js/packages/container/lib/container.js

Line 408 in 9b3d581

container.registry.validateInjections(injections);

This is likely why I get test failures when using expectAssertion

[GavinJoyce]

I'm going to wrap the validateInjections in a runInDebug and change the Error to an assert

[GavinJoyce]

@rwjblue I believe that this is ready to go (I think the failing CI is just sauce labs flakiness).

I've wrapped a container.registry.validateInjections(injections) in a runInDebug so we get a bonus performance improvement

[rwjblue]

LGTM, I restarted the sauce labs job.

[GavinJoyce]

It's 🍏, thanks

[spruce]

Hey,
I just ran into this problem with my addon ember-rapid-forms. Where it is possible to to use i18n but not a requirement. But with this change it fails the tests. Is there a way to walk around this issue. Maybe even a better way to support it. I have no better idea. Could you help? See here: https://travis-ci.org/piceaTech/ember-rapid-forms/jobs/207164170#L593

[GavinJoyce]

@spruce this should help you: RSSchermer/ember-multiselect-checkboxes#41

[rwjblue]

I submitted piceaTech/ember-rapid-forms#153 to fix at least one example scenario in ember-rapid-forms.