Refactor ember-metal/lib/transaction module.#14876
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jan 26, 2017
Merged
Conversation
* Remove ambiguity around `raise` (is it an `assert` or is it a `deprecate` call). * Remove dead code. * Simplify ember-glimmer/lib/renderer by moving default implementation for `runInTransaction` into `ember-metal/lib/transaction`.
Member
Author
|
https://github.com/emberjs/ember.js/pull/14876/files?w=1 is a tad easier to read (most of the changes to the guts of |
Member
|
Looks good, nice one. I tried a normal build and an ALLOW_BACKTRACKING=true build and both behave as expected. 👍 |
Member
Author
|
Thank you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raise(is it anassertor is it adeprecatecall).runInTransactioninto
ember-metal/lib/transaction.