small cleanup of eachDestroyable#15010
Merged
stefanpenner merged 3 commits intoemberjs:masterfrom Mar 15, 2017
Merged
Conversation
stefanpenner
approved these changes
Mar 14, 2017
Member
|
@bekzod looks good! |
Contributor
Author
|
will be it too much if I change |
Member
nope, sounds good. |
Member
|
@homu r+ |
Contributor
|
📌 Commit dc2abee has been approved by |
Contributor
homu
added a commit
that referenced
this pull request
Mar 14, 2017
small cleanup of eachDestroyable Since utility function `eachDestroyable` iterates destroyable items, and most of the time probably destroyable items iterated to be destroyed, I think it is better to destroy them immediately. Free to reject if I am misunderstanding something :P
Contributor
|
💥 Test timed out |
Member
|
@homu retry |
Contributor
homu
added a commit
that referenced
this pull request
Mar 14, 2017
small cleanup of eachDestroyable Since utility function `eachDestroyable` iterates destroyable items, and most of the time probably destroyable items iterated to be destroyed, I think it is better to destroy them immediately. Free to reject if I am misunderstanding something :P
Contributor
|
💥 Test timed out |
Contributor
|
☔ The latest upstream changes (presumably #15014) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
needs rebase I believe |
bekzod
force-pushed
the
destroy-destroyables
branch
from
dc2abee to
462bab0
Compare
Contributor
Author
|
rebased :) |
stefanpenner
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since utility function
eachDestroyableiterates destroyable items, and most of the time probably destroyable items iterated to be destroyed, I think it is better to destroy them immediately.Free to reject if I am misunderstanding something :P