Skip to content

[Project Svelte] Add deprecation flags#15066

Merged
chadhietala merged 1 commit intoemberjs:masterfrom
chadhietala:we-shave-yaks
Apr 11, 2017
Merged

[Project Svelte] Add deprecation flags#15066
chadhietala merged 1 commit intoemberjs:masterfrom
chadhietala:we-shave-yaks

Conversation

@chadhietala
Copy link
Contributor

Currently this is a WIP based on #15062. Need a Confirm/Deny on a couple versions and then we can start marking code paths that can be safely stripped.

@jonnii
Copy link

jonnii commented Mar 24, 2017

@chadhietala there has never been an expectation for svelte builds, is the goal to produce svelte builds for pre-2.12/13 versions? If not would it be ok to have the deprecations only stripped from 2.13 onwards?

@rwjblue
Copy link
Member

rwjblue commented Mar 24, 2017

@jonnii - I agree that it seems pretty unlikely that we would support consuming anything older than ember-source@2.14 and getting to "svelte out" deprecated features, but either way we have to instrument the code (for both new and old deprecations) and it seems better to put the "real" version numbers in there "since we are in there"...

@jonnii
Copy link

jonnii commented Mar 24, 2017

@rwjblue makes sense, i suppose it's good to know when a deprecation went into affect outside of the svelte builds. that information could be used in the docs and in places like ember-try. 👍

@rwjblue
Copy link
Member

rwjblue commented Apr 3, 2017

@chadhietala - This can land, right?

@chadhietala chadhietala changed the title [WIP Project Svelte] Mark code paths with deprecation flags [Project Svelte] Add deprecation flags Apr 11, 2017
@chadhietala chadhietala merged commit 64afb55 into emberjs:master Apr 11, 2017
@chadhietala chadhietala deleted the we-shave-yaks branch April 11, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants