[BUGFIX release] ensure “pause on exception” pauses in the right place

[stefanpenner]

It is quite common (like in ember-data’s tests) to not have a global onError handler in tests.
But because of the previous state of code, we would still end up paused in the default dispatchError rather then where the actual error was thrown.

This addresses the issue, but ensuring onErrorTarget.onerror returns undefined if no onError has been set

before:

After:

[rwjblue]

I think we also need a test for this. Something like:

import { 
  onErrorTarget,
  getDispatchOverride,
  setDispatchOverride,
  getOnerror,
  setOnerror
 } from '../error_handler';

const DISPATCH_OVERRIDE = getDispatchOverride();
const ONERROR = getOnerror();

module('error_handler', {
  afterEach() {
    setOnerror(ONERROR);
    setDispatchOverride(DISPATCH_OVERRIDE);
  }
});

test('by default there is no onerror', function(assert) {
  assert.equal(onErrorTarget.onerror, undefined);
});

test('when dispatch override is registered', function(assert) {
  assert.expect(2);
  let override = () => assert.ok(true, 'dispatch called');
  setDispatchOverride(overide);
  assert.equal(onErrorTarget.onerror, override);
});

test('when onerror is registered', function(assert) {
  assert.expect(2);
  let override = () => assert.ok(true, 'onerror called');
  setOnerror(overide);
  assert.equal(onErrorTarget.onerror, override);
});

[rwjblue]

Maybe I'm missing something, but I don't see how this works since dispatchError is always defined just below here?

I would think you want this to actually be:

export const onErrorTarget = {
  get onerror() {
    return getDispatchOverride() || getOnerror();
  }
}

[stefanpenner]

yup, test looks good. Adding it

[rwjblue]

@stefanpenner - We should consider backporting this to 2.12 LTS. Thoughts?

[stefanpenner]

There appears to be a BB issue preventing this from working correctly.

[stefanpenner]

I think -> BackburnerJS/backburner.js#262 fixes the BB issue

[stefanpenner]

ya that BB fix address this (linked locally)

[stefanpenner]

oh GH you so silly... #15600