[DEPRECATION canary] Deprecate Ember.String and prototype extension by Serabe · Pull Request #15739 · emberjs/ember.js

Serabe · 2017-10-13T15:46:21Z

This PR deprecates the use of String prototype extension and
Ember.String namespace.

Methods coming from ember-runtime

A new StringUtils object is added, to be used internally by Ember
instead of using the same object being exposed as Ember.String. This
simplifies testing and the changes required in the rest of the code.
Also, dropping the deprecated code will be much simpler.

Methods coming from ember-glimmer

Deprecated versions are being added and reexported as the same global
the non-deprecated versions were. Besides, the non-deprecated version is
being exported under the new global Ember.Template.

The Ember.Template is just a placeholder until the final global is chosen.

Serabe · 2017-10-23T23:18:57Z

@locks any update on this?

Serabe · 2017-11-17T18:52:57Z

restarting job. Seemed a problem with yarn.

Serabe · 2017-11-17T19:08:14Z

Passing.

rwjblue

Looking really good! Only a few small questions/adjustments that I commented on inline...

rwjblue · 2017-11-18T18:52:48Z

packages/ember-glimmer/lib/utils/string.ts

+    {
+      id: 'ember-glimmer.ember-string-html-safe',
+      until: '3.5.0',
+      url: ''


Do we know the URL's for these deprecations? I vaguely recall that there was already an open website PR for them...

Adding the URL from https://github.com/emberjs/website/pull/2995/files

rwjblue · 2017-11-18T18:54:45Z

packages/ember-runtime/lib/ext/string.js

 const StringPrototype = String.prototype;

+function deprecateEmberStringExtension(fn, opts = {}) {
+  let { name } = fn;


I don't think we can rely on Function.name (AFAIK it isn't supported on all platforms, which would make this fail in production).

Checkout https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name for a decent compat table (it isn't supported on IE at all)...

rwjblue · 2017-11-18T18:58:44Z

packages/ember-runtime/lib/system/string.js

  return CAPITALIZE_CACHE.get(str);
 }

+function deprecateEmberStringUtil(fn, opts = {}) {


This seems roughly like the same function in the other file, can we share between the two and only have one implementation?

rwjblue · 2017-11-18T18:58:59Z

packages/ember-runtime/lib/system/string.js

 }

+function deprecateEmberStringUtil(fn, opts = {}) {
+  let { name } = fn;


Same concern as above RE: Function.name

rwjblue · 2017-11-18T19:00:35Z

packages/ember/lib/index.js

+ @type Object
+ @private
+ */
+Ember.Template = {


Lets underscore this, I'd hate for folks to start using it ....

Serabe · 2017-11-19T23:02:33Z

Addressed your suggestions. Thanks for the review!

Serabe · 2017-12-11T23:37:17Z

Rebased and squashed.

Serabe · 2018-02-05T00:37:54Z

Having lots of timeouts while doing yarn install in CI

Serabe · 2018-02-05T00:59:46Z

Yay! I got tests passing after restarting some jobs several times.

mmun · 2018-02-25T08:29:36Z

@rwjblue should we merge this?

locks · 2018-02-25T10:46:54Z

@mmun negatory, sir. we need to publish the deprecation guides and release the addon before.
sorry for dwelling on this 😞

Serabe · 2018-03-16T16:00:56Z

Rebased!

Serabe · 2018-03-16T16:00:56Z

Rebased!

Serabe · 2018-03-31T15:32:39Z

I will rebase this at some point, quite likely, next Friday. Would that be ok, @locks ?

Serabe · 2018-04-06T12:36:23Z

I redid the whole PR because this rebase was going to be harder than redoing everything.

This PR deprecates the use of String prototype extension and Ember.String namespace. Methods coming from ember-runtime --- A new `StringUtils` object is added, to be used internally by Ember instead of using the same object being exposed as `Ember.String`. This simplifies testing and the changes required in the rest of the code. Also, dropping the deprecated code will be much simpler. Methods coming from ember-glimmer --- Deprecated versions are being added and reexported as the same global the non-deprecated versions were. Besides, the non-deprecated version is being exported under the new global `Ember.Template`. The `Ember.Template` is just a placeholder until the final global is chosen.

Serabe · 2018-04-06T14:10:51Z

Green again.

Serabe · 2018-04-13T18:03:27Z

Closing this. Sorry, I cannot keep rebasing this.

locks · 2018-04-17T10:29:46Z

Sorry 😢I'll wait for #16530.

Serabe changed the title ~~[DEPRECATION alpha] Deprecate Ember.String an prototype extension~~ [DEPRECATION canary] Deprecate Ember.String an prototype extension Oct 13, 2017

Serabe force-pushed the feature/deprecate-ember-string branch from 04075a9 to 37a06d4 Compare October 13, 2017 15:50

locks self-assigned this Oct 16, 2017

Serabe mentioned this pull request Oct 23, 2017

WIP | Deprecate Ember.String methods and prototype extensions #15625

Closed

Serabe force-pushed the feature/deprecate-ember-string branch from 4abca4f to e27061b Compare November 17, 2017 18:16

rwjblue reviewed Nov 18, 2017

View reviewed changes

rwjblue approved these changes Nov 19, 2017

View reviewed changes

Serabe force-pushed the feature/deprecate-ember-string branch 2 times, most recently from e6c86fc to cf9e15b Compare November 29, 2017 23:59

Serabe force-pushed the feature/deprecate-ember-string branch 3 times, most recently from c257d81 to e0c7a5f Compare December 11, 2017 23:36

locks changed the title ~~[DEPRECATION canary] Deprecate Ember.String an prototype extension~~ [DEPRECATION canary] Deprecate Ember.String and prototype extension Dec 11, 2017

locks mentioned this pull request Dec 12, 2017

[RFC 236] Ember.String Deprecation for @ember/string #15624

Closed

8 tasks

Serabe force-pushed the feature/deprecate-ember-string branch from e0c7a5f to f7e9fca Compare December 22, 2017 13:32

Serabe force-pushed the feature/deprecate-ember-string branch 2 times, most recently from fe778f1 to a672acb Compare January 5, 2018 17:47

Serabe force-pushed the feature/deprecate-ember-string branch from a672acb to e9a150c Compare February 5, 2018 00:15

Serabe force-pushed the feature/deprecate-ember-string branch from e9a150c to 5b80853 Compare February 7, 2018 13:19

Serabe force-pushed the feature/deprecate-ember-string branch from 5b80853 to c034404 Compare March 16, 2018 16:00

Serabe force-pushed the feature/deprecate-ember-string branch from c034404 to d874956 Compare April 6, 2018 12:35

Serabe force-pushed the feature/deprecate-ember-string branch from d874956 to 4fc3dd5 Compare April 6, 2018 13:40

Serabe closed this Apr 13, 2018

kategengler mentioned this pull request Apr 5, 2019

RFC #0236 - Tracking for Ember.String deprecation emberjs/rfc-tracking#26

Closed

17 tasks

Uh oh!

Conversation

Serabe commented Oct 13, 2017

Methods coming from ember-runtime

Methods coming from ember-glimmer

Uh oh!

Serabe commented Oct 23, 2017

Uh oh!

Serabe commented Nov 17, 2017

Uh oh!

Serabe commented Nov 17, 2017

Uh oh!

rwjblue left a comment

Choose a reason for hiding this comment

Uh oh!

rwjblue Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

Serabe Nov 19, 2017

Choose a reason for hiding this comment

Uh oh!

rwjblue Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

rwjblue Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

rwjblue Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

rwjblue Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

Serabe commented Nov 19, 2017

Uh oh!

Serabe commented Dec 11, 2017

Uh oh!

Serabe commented Feb 5, 2018

Uh oh!

Serabe commented Feb 5, 2018

Uh oh!

mmun commented Feb 25, 2018

Uh oh!

locks commented Feb 25, 2018

Uh oh!

Serabe commented Mar 16, 2018

Uh oh!

Serabe commented Mar 16, 2018

Uh oh!

Serabe commented Mar 31, 2018

Uh oh!

Serabe commented Apr 6, 2018

Uh oh!

Serabe commented Apr 6, 2018

Uh oh!

Serabe commented Apr 13, 2018

Uh oh!

locks commented Apr 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants