Skip to content

[doc release]mv doc from @ember/string to @ember/template#15846

Closed
toddjordan wants to merge 1 commit intoemberjs:masterfrom
toddjordan:move-string-fns-to-template
Closed

[doc release]mv doc from @ember/string to @ember/template#15846
toddjordan wants to merge 1 commit intoemberjs:masterfrom
toddjordan:move-string-fns-to-template

Conversation

@toddjordan
Copy link
Contributor

@toddjordan toddjordan commented Nov 10, 2017

Part of emberjs/rfcs#236.
Closes #15626.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll leave it to @locks for merging (not sure of the exact version that we are targetting with the deprecation)...

@locks
Copy link
Contributor

locks commented Nov 16, 2017

How tied to ember-cli/ember-rfc176-data#38 is this? Or do we have time because of the train release cycle?

@locks locks self-assigned this Nov 16, 2017
@toddjordan
Copy link
Contributor Author

Also, do we need to add @deprecated to these?

@locks
Copy link
Contributor

locks commented Nov 16, 2017

@toddjordan we need to add documentation for the @ember/string ones and deprecate those.

@toddjordan
Copy link
Contributor Author

toddjordan commented Nov 16, 2017 via email

@mmun
Copy link
Member

mmun commented Feb 24, 2018

This was merged in #15626.

@mmun mmun closed this Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants