Merged
Conversation
chancancode
force-pushed
the
named-args
branch
3 times, most recently
from
326b809 to
ba3d5a9
Compare
chancancode
force-pushed
the
named-args
branch
from
0eb0c95 to
5f5b434
Compare
rwjblue
reviewed
Dec 12, 2017
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks great! Just need to figure out the official path forward on the TBD stuff...
| url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options' | ||
| } | ||
| ); | ||
| if (until !== 'TBD' || ENV._ENABLE_TBD_DEPRECATIONS === true) { |
Member
There was a problem hiding this comment.
Just flagging this as needing a bit more discussion / thought before landing.
Leftover from #15890
chancancode
force-pushed
the
named-args
branch
from
5f5b434 to
f1a3b24
Compare
Member
Author
|
I removed the TBD/deprecations from this PR and opened #15970 for those |
Also added a feature to the test harness for testing optional features
chancancode
force-pushed
the
named-args
branch
from
f1a3b24 to
22fda11
Compare
rwjblue
approved these changes
Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{@foo}}) rfcs#276{{@foo}}{{@args}},{{@arguments}}@0,@1,@$, ...)Added a "TBD" deprecation feature that allows the code paths to be flagged without rolling the deprecations out to users immediately. This is an internal, undocumented feature that is not intended to be used by libraries and apps (yet, should go through an RFC at least), and the API/implementation are subject to change.(Add internal "TBD" deprecations feature #15970)Flagged(Add internal "TBD" deprecations feature #15970){{attrs.*}}for future deprecation