Implement template-only components RFC#15974
Merged
chancancode merged 2 commits intomasterfrom Dec 13, 2017
Merged
Conversation
chancancode
force-pushed
the
template-only-component
branch
from
c617d93 to
cb8aad2
Compare
chancancode
changed the title
rwjblue
approved these changes
Dec 13, 2017
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks good to me! There are some follow-up items that we need to tackle as the RFC progresses (e.g. runtime flag, can we rely on ember-source being consumed as an addon, etc), but those should likely be addressed in a separate PR.
…nly components RFC
chancancode
force-pushed
the
template-only-component
branch
from
beb304e to
0fd6f64
Compare
chancancode
commented
Dec 13, 2017
| } | ||
|
|
||
| compile(builder: any) { | ||
| // TODO: use fromLayout |
Member
Author
There was a problem hiding this comment.
I think @krisselden told me fromLayout is broken on this version of Glimmer, so I didn't bother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC