Skip to content

add ability to pass log helper as action#17568

Closed
bekzod wants to merge 1 commit intoemberjs:masterfrom
bekzod:log-action
Closed

add ability to pass log helper as action#17568
bekzod wants to merge 1 commit intoemberjs:masterfrom
bekzod:log-action

Conversation

@bekzod
Copy link
Contributor

@bekzod bekzod commented Feb 6, 2019

so following is possible:

  <button {{log 'rainbow'}}>Click!</button> // logs `rainbow` and `MouseEvent` on click
  <button onclick={{log 'rainbow'}}>Click!</button> // logs `rainbow` and `MouseEvent` on click
  <button onclick={{action (log 'rainbow') 'sun'}}>Click!</button>  // logs `rainbow`,  'sun' and `MouseEvent` on click

@bekzod bekzod force-pushed the log-action branch 5 times, most recently from 13490e2 to 1d170ed Compare February 6, 2019 12:38
@rwjblue
Copy link
Member

rwjblue commented May 8, 2020

I think we would want to leverage emberjs/rfcs#432 for this kind of thing instead.

If we went this route, we'd need an RFC to change the behavior. I'm going to close for now (in favor of either implementing emberjs/rfcs#432 or a new RFC).

@rwjblue rwjblue closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants