[DEPRECATE] - RFC 421 - deprecate app ctrl router props#17573
Merged
chadhietala merged 1 commit intoemberjs:masterfrom Feb 15, 2019
Merged
[DEPRECATE] - RFC 421 - deprecate app ctrl router props#17573chadhietala merged 1 commit intoemberjs:masterfrom
chadhietala merged 1 commit intoemberjs:masterfrom
Conversation
mistahenry
force-pushed
the
deprecate/app-ctrl-route-props
branch
from
8cf759f to
374865a
Compare
Closed
2 tasks
Contributor
|
Can you add the following URL to the deprecation, |
mistahenry
force-pushed
the
deprecate/app-ctrl-route-props
branch
from
374865a to
b43cf34
Compare
Author
|
@locks Updated the deprecation with the url/ matching deprecation id |
chadhietala
suggested changes
Feb 13, 2019
Contributor
chadhietala
left a comment
chadhietala
left a comment
There was a problem hiding this comment.
This looks great! Thanks for doing this, just a couple small things we need to address before merging.
Closed
3 tasks
mistahenry
force-pushed
the
deprecate/app-ctrl-route-props
branch
2 times, most recently
from
7232a55 to
b2f888f
Compare
… currentRoute and currentRouteName properties
mistahenry
force-pushed
the
deprecate/app-ctrl-route-props
branch
from
b2f888f to
ce7841f
Compare
Contributor
|
Thanks so much @mistahenry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RFC #421.
Part of #17569.
Please let me know if
notifyPropertyChangewas an okay way to solve this.