[BUGFIX release] Ensure query param only link-to's work in error states.#17971
Merged
rwjblue merged 2 commits intoemberjs:masterfrom Jun 14, 2019
Merged
[BUGFIX release] Ensure query param only link-to's work in error states.#17971rwjblue merged 2 commits intoemberjs:masterfrom
rwjblue merged 2 commits intoemberjs:masterfrom
Conversation
rwjblue
reviewed
Apr 25, 2019
cd43696 to
21edc29
Compare
Contributor
Author
|
I try to add one test in "packages/@ember/-internals/glimmer/tests/integration/components/link-to/query-params-curly-test.js", but with no success. The test need an @rwjblue Do you have any idea on how to write this previously failing test? Thank you! |
Contributor
Contributor
|
we are trying fix this on engines side as well - ember-engines/ember-engines#647 |
Contributor
|
@2hu12 unfortunately I don't was able to write tests for this =/ |
… route. Reproduce failure in emberjs#17963: `<LinkTo>` without `@route` param but with `@query` breaks when navigating to error route. Co-authored-by: Robert Jackson <me@rwjblue.com>
Member
Contributor
|
thanks @rwjblue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #17963, I'm not sure this is the right way and it's weird, but the old "qualifiedRouteName" property works in this way and "_route" is used similarly to "qualifiedRouteName".