[WIP] [BUGFIX] Make RouterService.transitionTo engine aware#18569
Closed
Gaurav0 wants to merge 1 commit intoemberjs:masterfrom
Closed
[WIP] [BUGFIX] Make RouterService.transitionTo engine aware#18569Gaurav0 wants to merge 1 commit intoemberjs:masterfrom
Gaurav0 wants to merge 1 commit intoemberjs:masterfrom
Conversation
Contributor
|
Related ember-engines/ember-engines#669 |
Contributor
|
This is still legit issue, will hijack the PR and refresh or open a new one cc @locks |
Contributor
|
This should not be needed once emberjs/rfcs#819 gets accepted/implemented as Engines would supply it's own version of |
Contributor
|
Thanks for the update! I'll close the PR so the work is tracked together with the RFC work mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #17014