[FEATURE modernized-built-in-components] Initial implementation#19184
Merged
[FEATURE modernized-built-in-components] Initial implementation#19184
Conversation
This implements some of the deprecations proposed in [RFC #671][1]. The deprecations are gated behind the feature flag so they won't be visible until the RFC is merged and the feature is enabled. [1]: emberjs/rfcs#671
chancancode
commented
Oct 6, 2020
| if (featureValue === true || featureValue === false) { | ||
| return featureValue; | ||
| if (value === true || value === false) { | ||
| return value; |
Member
Author
There was a problem hiding this comment.
I think I did this because at one point the linter complained that featureValue is already defined in the outer scope (the function on L67). Not sure why it was complaining then and why it stopped complaining now, but it seems good to address it anyway since it can indeed be a bit confusing.
rwjblue
approved these changes
Oct 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the feature flag for RFC #671 and start implementing some of the proposed deprecations. The deprecations are gated behind the feature flag so they won't be visible until the RFC is merged and the feature is enabled.