[RFC#236] Deprecate String prototype extensions#19234
Merged
Conversation
locks
changed the title
17 tasks
locks
force-pushed
the
deprecate-ember-string-prototype-extension
branch
from
e94b9bf to
f22a636
Compare
Merged
2 tasks
locks
force-pushed
the
deprecate-ember-string-prototype-extension
branch
from
f22a636 to
ec07cdc
Compare
rwjblue
requested changes
Oct 27, 2020
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Will need to wrap the prototype extension tests in expectDeprecation
locks
force-pushed
the
deprecate-ember-string-prototype-extension
branch
from
c29007e to
6e1c963
Compare
rwjblue
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of emberjs/rfc-tracking#26.
PR twin of ember-learn/deprecation-app#696.
This PR deprecate using the
String.prototypeextension version of@ember/stringmethods.Calling
"Tomster and Zoey".underscore()will throw a deprecation error.I did not apply the wrapper method to
locas that is completely deprecated and has its own id.