[BUGFIX lts] LinkTo with incomplete model failing in rendering tests

[xg-wang]

LinkTo needs route context to allow omitting model from current active
route. Without the guard, tests where LinkTo rendered in tests without
routing transition started will break. See #19364

Add failing test before the fix:
While generating link to route "dynamicWithChild.child": can't access
property "shouldSupercede", newHandlerInfo is undefined

[xg-wang]

This PR and #19080 should go into 3.24 (LTS)

[rwjblue]

Looks good, can you prefix the commit message with [BUGFIX lts]? That is what let's us know to cherry pick things back into the current LTS (3.24).

[xg-wang]

@rwjblue do I also need to cherry-pick #19326 and title it [BUGFIX lts] and [BUGFIX release]?

[rwjblue]

@rwjblue do I also need to cherry-pick #19326 and title it [BUGFIX lts] and [BUGFIX release]?

No, I'll take care of that.

[rwjblue]

Done, 3.25.1 is released and 3.24.2 is mid-release.

[rogeraraujo90]

Hello everyone, regarding this fix, The LinkTo component will not render href anymore during Integration tests?

My Integration test did an assert in the link in the Ember 3.20 that started fail in Ember 3.24.

[lougreenwood]

@rogeraraujo90 Do you still have a problem here? Seems that I just noticed that <LinkTo @route="bla"> where bla has a dynamic segment doesn't generate an href in integration tests.

[rogeraraujo90]

@lougreenwood try add this.owner.setupRouter(); in the beforeEach hook!

[lougreenwood]

Thanks, @rogeraraujo90, did that solve it for you?

I'm also already using setupRouter (and as I understand it, it should be necessary in 3.28 anymore) - seems to be a bug where if there is no @model arg on the linkTo and the linkTo points to a route with dynamic segments, the href isn't added to the linkTo.

I've reproduced by both linking to routes without dynamic segments (href is added) and also adding arbitrary @model="1" to the template being tested, which also works.

The links work fine in acceptance tests and production.

I'm planning on creating a minimal repto tomorrow and finding the release where this gets broken.

[rogeraraujo90]

Thanks, @rogeraraujo90, did that solve it for you?

I'm also already using setupRouter (and as I understand it, it should be necessary in 3.28 anymore) - seems to be a bug where if there is no @model arg on the linkTo and the linkTo points to a route with dynamic segments, the href isn't added to the linkTo.

I've reproduced by both linking to routes without dynamic segments (href is added) and also adding arbitrary @model="1" to the template being tested, which also works.

The links work fine in acceptance tests and production.

I'm planning on creating a minimal repto tomorrow and finding the release where this gets broken.

Good, go ahead!

I'm in Ember 3.24 yet, and using setupRouter the href is being generated correctly in the integration tests. To be more specific. my project is running 3.24.5

[lougreenwood]

@rogeraraujo90 Do you still have a problem here? Seems that I just noticed that <LinkTo @route="bla"> where bla has a dynamic segment doesn't generate an href in integration tests.

[rogeraraujo90]

@lougreenwood try add this.owner.setupRouter(); in the beforeEach hook!

[lougreenwood]

Thanks, @rogeraraujo90, did that solve it for you?

I'm also already using setupRouter (and as I understand it, it should be necessary in 3.28 anymore) - seems to be a bug where if there is no @model arg on the linkTo and the linkTo points to a route with dynamic segments, the href isn't added to the linkTo.

I've reproduced by both linking to routes without dynamic segments (href is added) and also adding arbitrary @model="1" to the template being tested, which also works.

The links work fine in acceptance tests and production.

I'm planning on creating a minimal repto tomorrow and finding the release where this gets broken.

[rogeraraujo90]

Thanks, @rogeraraujo90, did that solve it for you?

I'm also already using setupRouter (and as I understand it, it should be necessary in 3.28 anymore) - seems to be a bug where if there is no @model arg on the linkTo and the linkTo points to a route with dynamic segments, the href isn't added to the linkTo.

I've reproduced by both linking to routes without dynamic segments (href is added) and also adding arbitrary @model="1" to the template being tested, which also works.

The links work fine in acceptance tests and production.

I'm planning on creating a minimal repto tomorrow and finding the release where this gets broken.

Good, go ahead!

I'm in Ember 3.24 yet, and using setupRouter the href is being generated correctly in the integration tests. To be more specific. my project is running 3.24.5