Change the mount API to accept a function for defining engine routes#19402
Draft
jsturgis wants to merge 1 commit intoemberjs:mainfrom
Draft
Change the mount API to accept a function for defining engine routes#19402jsturgis wants to merge 1 commit intoemberjs:mainfrom
jsturgis wants to merge 1 commit intoemberjs:mainfrom
Conversation
This change updates the mount API method to accept a function similar to how the route API currently works so that engine routes can be defined in the host application's router.js file. Some Ember applications utilize in-repo ember-engines strictly for their lazy loading and code organization features and not for their isolation features. In this context it makes more sense to define engine routes in the host application's router.js file.
jsturgis
changed the title
Member
|
Is this still relevant? It is a draft PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the mount API method to accept a function similar
to how the route API currently works so that engine routes can be defined
in the host application's router.js file.
Some Ember applications utilize in-repo ember-engines strictly for their
lazy loading and code organization features and not for their isolation features.
In this context it makes more sense to define engine routes in the host application's
router.js file.
RFC