[CLEANUP] remove feature flags for shipped features#20018
Merged
kategengler merged 1 commit intoemberjs:masterfrom Mar 15, 2022
Merged
[CLEANUP] remove feature flags for shipped features#20018kategengler merged 1 commit intoemberjs:masterfrom
kategengler merged 1 commit intoemberjs:masterfrom
Conversation
locks
reviewed
Mar 13, 2022
Contributor
locks
left a comment
locks
left a comment
There was a problem hiding this comment.
Seems good but I'll wait to approve until the linting problem is resolved, mas the change to broccoli/package.js seems unrelated to the PR's goal.
- router service refresh - shipped in 4.1 - cached - shipped in 4.1
NullVoxPopuli
force-pushed
the
remove-flags-for-shipped-features
branch
from
d249ddb to
6076d2f
Compare
Contributor
Author
|
Updated |
locks
approved these changes
Mar 15, 2022
kategengler
changed the title
kategengler
approved these changes
Mar 15, 2022
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting is failing, but is fixed here: #20019