Ember.A should not modify underlying array by wagenet · Pull Request #20245 · emberjs/ember.js

wagenet · 2022-10-31T21:07:00Z

Resolves #20219

wagenet · 2022-10-31T22:39:26Z

packages/@ember/array/index.ts

+
+const emberArrayLastObject = nonEnumerableComputed(function () {
+  return objectAt(this, this.length - 1);
+}).readOnly();


I don't love how we're assigning them to variables here, but I can't find any other good way to get a reference to their CPs.

wagenet · 2022-10-31T22:40:21Z

packages/@ember/array/index.ts

+    let proxy = new Proxy(arr, {
+      get(target, prop /*, _receiver */) {
+        // These nonEnumerableComputed properties need special handling
+        if (prop === '[]') {


Ideally we'd have something more generic, but we aren't going to be adding stuff to EmberArray going forwards so this should be fine.

chriskrycho · 2022-11-01T00:58:46Z

@wagenet note that "Extend Prototypes" is failing on CI.

chriskrycho

This seems reasonable to me, but I'd still really like it if someone who's more familiar with this could give it some 👀 as well. @rwjblue do you have 10 minutes (tops) to look at it?

wagenet · 2022-11-22T23:54:00Z

I think I'd like to put this behind a flag. I think (hope) it won't cause issues for people, but who knows what people are actually doing and whether they're relying on the mutating behavior.

jrjohnson · 2023-01-04T21:37:18Z

I agree that it should go behind a flag. Because many addons call A() on basically everything there are probably lots of components in production today that pass something through an addon helper such as {{map-by "id" this.posts}} and then rely on some prototype pollution elsewhere in a getter or action without realizing that the template code had modified the original this.posts. Being able to opt into this change seems like a good way to find out where the breaks are outside of the full deprecation in emberjs/rfcs#864

locks · 2023-08-04T15:17:12Z

@wagenet I'm working on pushing tracked-built-ins to recommended and saw this PR. Is this something we still want to push forward?

wagenet · 2023-08-18T15:41:13Z

@locks This was partially motivated by issues Ember Data was having. @runspired what's the status of that stuff?

runspired · 2023-08-21T05:20:24Z

still needed. iirc the solution for most has been to turn prototype extensions back on

kategengler · 2023-12-12T16:38:36Z

Is this still relevant?

runspired · 2023-12-14T23:10:40Z

@kategengler I believe so

kategengler · 2023-12-14T23:32:22Z

@wagenet should we merge then?

wagenet · 2024-01-10T21:39:43Z

@kategengler I would like to and it is flagged so it should be safe. That said, I haven't really gotten a proper review from anyone still.

kategengler · 2024-01-10T21:55:06Z

@kategengler I would like to and it is flagged so it should be safe. That said, I haven't really gotten a proper review from anyone still.

I don't have a clue here or I would offer you one :) I'm just triaging PRs.

NullVoxPopuli · 2024-01-11T15:33:03Z

can this be rebasod?

NullVoxPopuli · 2024-01-11T20:36:12Z

packages/@ember/array/index.ts

-      // SAFETY: This will return an NativeArray but TS can't infer that.
-      return NativeArray.apply(arr ?? []) as NativeArray<T>;
+      if (EMBER_A_NON_MODIFYING) {
+        // Remove this in Ember 5.0.


Heh... should be 6.0 now, I guess.

wagenet marked this pull request as ready for review October 31, 2022 22:38

wagenet commented Oct 31, 2022

View reviewed changes

wagenet force-pushed the ember-a-improvements branch from 7dd16a6 to 7aa79fa Compare November 1, 2022 15:11

chriskrycho reviewed Nov 4, 2022

View reviewed changes

wagenet mentioned this pull request Nov 22, 2022

Deprecate Ember.A emberjs/rfcs#864

Closed

wagenet force-pushed the ember-a-improvements branch from 7aa79fa to 0b2ab6f Compare November 23, 2022 15:55

wagenet force-pushed the ember-a-improvements branch 2 times, most recently from 00ccece to 582831f Compare January 3, 2023 23:16

wagenet force-pushed the ember-a-improvements branch from 582831f to 331a4a6 Compare March 7, 2023 17:12

MelSumner requested review from a team and chriskrycho March 24, 2023 21:27

wagenet added 4 commits January 11, 2024 08:25

Ember.A no longer modifies the original array

38242b5

Add EMBER_A_NON_MODIFYING flag

05ce8b3

Fix rebase

ac45479

Fix tests

dd75266

wagenet force-pushed the ember-a-improvements branch from 331a4a6 to dd75266 Compare January 11, 2024 16:25

NullVoxPopuli reviewed Jan 11, 2024

View reviewed changes

Uh oh!

Conversation

wagenet commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wagenet Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

wagenet Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

chriskrycho commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chriskrycho left a comment

Choose a reason for hiding this comment

Uh oh!

wagenet commented Nov 22, 2022

Uh oh!

jrjohnson commented Jan 4, 2023

Uh oh!

locks commented Aug 4, 2023

Uh oh!

wagenet commented Aug 18, 2023

Uh oh!

runspired commented Aug 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kategengler commented Dec 12, 2023

Uh oh!

runspired commented Dec 14, 2023

Uh oh!

kategengler commented Dec 14, 2023

Uh oh!

wagenet commented Jan 10, 2024

Uh oh!

kategengler commented Jan 10, 2024

Uh oh!

NullVoxPopuli commented Jan 11, 2024

Uh oh!

NullVoxPopuli Jan 11, 2024

Choose a reason for hiding this comment

Uh oh!

wagenet Jan 12, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wagenet commented Oct 31, 2022 •

edited

Loading

chriskrycho commented Nov 1, 2022 •

edited

Loading

runspired commented Aug 21, 2023 •

edited

Loading