Remove escapeExpression from @ember/template#20360
Closed
chriskrycho wants to merge 1 commit intomainfrom
Closed
Conversation
This is unused elsewhere in the framework itself and is not public API, so it should be safe to remove. Additionally, since this is just a copy of the API from within Handlebars itself, users who want to use it should directly use Handlebars' (or some other library's) escaping library instead. See [the discussion at #16817][16817] for background. [16817]: #16817
chriskrycho
force-pushed
the
remove-escapeExpression
branch
from
1d0052e to
7d2addb
Compare
Member
|
Is this still relevant? |
Contributor
Author
|
I believe the answer is "yes", and if I recall correctly (which, it having been a bit, I may not!) this is perfectly land-able; I was simply waiting on someone (anyone!) else from Framework to review it rather than just unilaterally YOLO'ing it in. 😅 |
Member
|
Thanks for the update, @chriskrycho Do you have any interest in rebaseing? |
Contributor
|
I can take this across the line monday if work's still needed by then |
Member
Thank you! |
Member
|
ping @NullVoxPopuli |
Contributor
biggest lie of 2023 -- I'll rebase it now |
Contributor
Member
|
Closing in favor of rebased PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unused elsewhere in the framework itself and is not public API, so it should be safe to remove. Additionally, since this is just a copy of the API from within Handlebars itself, users who want to use it should directly use Handlebars' (or some other library's) escaping library instead. See the discussion at #16817 for background.