Adding stage3-compatible decorator implementations#20507
Closed
Conversation
(This should stay draft and not merge until we have some consensus on the ecosystem-spanning parts of the migration.)
This is an exploration to see how easy it is to make the ember-provided decorators work under both legacy decorators and stage3 decorators.
(I don't think it's hard!)
The first commit here implements `@tracked`. I tested it in an application with the configuration:
```js
const app = new EmberApp(defaults, {
'ember-cli-babel': {
disableDecoratorTransforms: true,
},
babel: {
plugins: [
[
'@babel/plugin-proposal-decorators',
{
version: '2023-05',
},
],
],
},
});
```
With those settings, `@tracked foo` becomes a runtime error and will tell you to use `@tracked accessor foo` instead, and when you do it all works correctly.
Member
|
Is this still relevant? It is a draft PR |
Contributor
Author
|
Still planning to pick this back up. Now that the build refactor has landed it's a bit easier to test. |
Contributor
Author
|
Superseded by #20868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This should stay draft and not merge until we have some consensus on the ecosystem-spanning parts of the migration.)
This is an exploration to see how easy it is to make the ember-provided decorators work under both legacy decorators and stage3 decorators.
(I don't think it's hard!)
The first commit here implements
@tracked. I tested it in an application with the configuration:With those settings,
@tracked foobecomes a runtime error and will tell you to use@tracked accessor fooinstead, and when you do it all works correctly.