Skip to content

VM Upgrade: T.S. '89 #20658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chancancode merged 36 commits into from
Apr 10, 2024
Merged

VM Upgrade: T.S. '89 #20658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ba9806b
T.S. '89
NullVoxPopuli Mar 9, 2024
68b591e
Handle VM breaking changes (new info for modifiers, updated AST)
NullVoxPopuli Mar 9, 2024
bdafc6f
Use non-deprecated AST Nodes
NullVoxPopuli Mar 9, 2024
612c61e
@babel/plugin-proposal-class-properties is required to build ember
NullVoxPopuli Mar 9, 2024
21eaca4
More plugins updates
NullVoxPopuli Mar 9, 2024
d84dea8
'89 -> '90
NullVoxPopuli Mar 22, 2024
445d6f3
'90 -> '91
NullVoxPopuli Mar 22, 2024
a849c75
New debug-render-tree-nodes to add to existing tests
NullVoxPopuli Mar 22, 2024
73eebf9
Very wip -- something may have gone wrong with the AST stuff in the VM
NullVoxPopuli Mar 22, 2024
751b767
shrug
NullVoxPopuli Mar 22, 2024
76fa19c
Finish updating debug-render-tree tests
NullVoxPopuli Mar 22, 2024
871396a
TODO: need to move assert-splattribute-expression to glimmer
NullVoxPopuli Mar 22, 2024
232105e
Move assert test for splattributes in {{ }} that is now a hard error …
NullVoxPopuli Mar 25, 2024
884fe58
0.90.1 -> 0.91.0
NullVoxPopuli Mar 25, 2024
50e3e07
Fix mistaken find and replace
NullVoxPopuli Mar 25, 2024
7a7b05a
Fix the state / scope tracker
NullVoxPopuli Mar 25, 2024
7e749c1
Remove mistaken plugin from strict-mode transforms
NullVoxPopuli Mar 25, 2024
7d94e76
Remove tests for code that was supposed to be removed in v4
NullVoxPopuli Mar 27, 2024
f7c53bf
Remove extraneous import
NullVoxPopuli Mar 27, 2024
2e4788b
0.91.0 -> 0.91.1
NullVoxPopuli Mar 28, 2024
cbb4530
Do not expose modifier manager states
NullVoxPopuli Mar 29, 2024
ce7acaf
Remove a !
NullVoxPopuli Mar 29, 2024
f0ec22d
Revert types/publish.mjs
NullVoxPopuli Mar 29, 2024
557f15d
Cleanup some types, don't use BlockStatement for scope tracking
NullVoxPopuli Mar 29, 2024
df09a3e
Fix old test: wrapper was not in scope
NullVoxPopuli Mar 29, 2024
d6f440a
restore/rewrite assert-splattribute-expression-test
NullVoxPopuli Mar 29, 2024
b3313c6
Remove default implementation of `getDebugInstance`
chancancode Mar 29, 2024
b0bd352
Remove outdated comment
chancancode Mar 29, 2024
6dabe69
add back `TransformEachTrackArray`
chancancode Mar 29, 2024
a249eb4
Re-apply Program -> Template fix after rebase
chancancode Mar 29, 2024
31e3d97
Missing Block visitor
chancancode Apr 4, 2024
cad1ca7
Additional coverage for strict mode keywords
chancancode Apr 4, 2024
db06d71
Pass list of strict mode keywords when calling precompile
chancancode Apr 4, 2024
481f2d0
0.91.1 -> 0.91.2
NullVoxPopuli Apr 5, 2024
0f4fc4d
0.91.2 -> 0.92.0
NullVoxPopuli Apr 8, 2024
c50e232
Update tests to accoutn for the (action) and {{action}} deprecation
NullVoxPopuli Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,24 +58,24 @@
"dependencies": {
"@babel/helper-module-imports": "^7.16.7",
"@ember/edition-utils": "^1.2.0",
"@glimmer/compiler": "0.87.1",
"@glimmer/compiler": "0.92.0",
"@glimmer/component": "^1.1.2",
"@glimmer/destroyable": "0.87.1",
"@glimmer/destroyable": "0.92.0",
"@glimmer/env": "^0.1.7",
"@glimmer/global-context": "0.87.1",
"@glimmer/interfaces": "0.87.1",
"@glimmer/manager": "0.87.1",
"@glimmer/node": "0.87.1",
"@glimmer/opcode-compiler": "0.87.1",
"@glimmer/owner": "0.87.1",
"@glimmer/program": "0.87.1",
"@glimmer/reference": "0.87.1",
"@glimmer/runtime": "0.87.1",
"@glimmer/syntax": "0.87.1",
"@glimmer/util": "0.87.1",
"@glimmer/validator": "0.87.1",
"@glimmer/vm": "0.87.1",
"@glimmer/vm-babel-plugins": "0.87.1",
"@glimmer/global-context": "0.92.0",
"@glimmer/interfaces": "0.92.0",
"@glimmer/manager": "0.92.0",
"@glimmer/node": "0.92.0",
"@glimmer/opcode-compiler": "0.92.0",
"@glimmer/owner": "0.92.0",
"@glimmer/program": "0.92.0",
"@glimmer/reference": "0.92.0",
"@glimmer/runtime": "0.92.0",
"@glimmer/syntax": "0.92.0",
"@glimmer/util": "0.92.0",
"@glimmer/validator": "0.92.0",
"@glimmer/vm": "0.92.0",
"@glimmer/vm-babel-plugins": "0.92.0",
"@simple-dom/interface": "^1.4.0",
"babel-plugin-debug-macros": "^0.3.4",
"babel-plugin-ember-template-compilation": "^2.1.1",
Expand Down Expand Up @@ -107,6 +107,7 @@
"devDependencies": {
"@aws-sdk/client-s3": "^3.321.1",
"@babel/core": "^7.22.9",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-decorators": "^7.23.6",
"@babel/plugin-transform-typescript": "^7.22.9",
"@babel/preset-env": "^7.16.11",
Expand Down
4 changes: 4 additions & 0 deletions packages/@ember/-internals/glimmer/lib/modifiers/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,10 @@ class ActionModifierManager implements InternalModifierManager<ActionState, obje
return new ActionState(element, owner, actionId, actionArgs, named, positional);
}

getDebugInstance(): unknown {
return null;
}

getDebugName(): string {
return 'action';
}
Expand Down
4 changes: 3 additions & 1 deletion packages/@ember/-internals/glimmer/lib/modifiers/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class InternalModifierState implements Destroyable {
constructor(readonly instance: InternalModifier) {}
}

export class InternalModifierManager
export abstract class InternalModifierManager
implements ModifierManager<InternalModifierState, typeof InternalModifier>
{
constructor(private ModifierClass: typeof InternalModifier, private name: string) {}
Expand All @@ -78,6 +78,8 @@ export class InternalModifierManager
return null;
}

abstract getDebugInstance(state: InternalModifierState): unknown;
Copy link
Contributor Author

@NullVoxPopuli NullVoxPopuli Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is what you meant

Copy link
Member

@chancancode chancancode Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it’s a little bit of an edge case because we are implementing an interface. If we are extending an abstract super class you wouldn’t have to explicitly propagate it like this.


getDebugName(): string {
return this.name;
}
Expand Down
Loading