Implement RFC#995, Deprecate component template resolution#20660
Implement RFC#995, Deprecate component template resolution#20660ef4 merged 32 commits intoemberjs:mainfrom
Conversation
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
deprecate-template-lookup
branch
2 times, most recently
from
1ea6b41 to
95e4c1e
Compare
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
Outdated
Show resolved
Hide resolved
| name: 'hello-world', | ||
| args: { positional: [], named: { name: 'first' } }, | ||
| instance: null, | ||
| template: 'my-app/templates/components/hello-world.hbs', |
There was a problem hiding this comment.
this field is based of moduleName, which we've talked about getting rid of.
It still works when a template is resolved, but when using setComponentTemplate, there is no module name to associate -- could come from anywhere
|
@mixonic volunteered to help review this |
| ['@test lifecycle hooks during component append'](assert) { | ||
| [`${testUnless( | ||
| DEPRECATIONS.DEPRECATE_COMPONENT_TEMPLATE_RESOLVING.isRemoved | ||
| )} lifecycle hooks during component append`](assert) { |
There was a problem hiding this comment.
This seems like test coverage that we would still want to keep after removing the deprecation?
There was a problem hiding this comment.
I can't figure this out -- test is too tied to specific VM behaviorss, it seems
There was a problem hiding this comment.
I did figure something out by not using any of the same test apis, and requiring slightly different assertions due to using the whole rendering system instead of manually creating factories, but I think the intent of the test is maintained in the new way
| ['@test appending, updating and destroying a single component'](assert) { | ||
| [`${testUnless( | ||
| DEPRECATIONS.DEPRECATE_COMPONENT_TEMPLATE_RESOLVING.isRemoved | ||
| )} appending, updating and destroying a single component`](assert) { |
There was a problem hiding this comment.
Similarly, I think we want to keep this test after deprecation removal?
There was a problem hiding this comment.
for all of the append tests: #20660 (comment)
There was a problem hiding this comment.
the newly added test covers these use cases (destroy and update)
| ['@test appending, updating and destroying multiple components'](assert) { | ||
| [`${testUnless( | ||
| DEPRECATIONS.DEPRECATE_COMPONENT_TEMPLATE_RESOLVING.isRemoved | ||
| )} appending, updating and destroying multiple components`](assert) { |
There was a problem hiding this comment.
the newly added test covers these use cases
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
Outdated
Show resolved
Hide resolved
NullVoxPopuli
force-pushed
the
deprecate-template-lookup
branch
2 times, most recently
from
42c360d to
265617e
Compare
…templates once the deprecation is in the removed state
NullVoxPopuli
force-pushed
the
deprecate-template-lookup
branch
from
6a59827 to
eb8fc81
Compare
4 participants
RFC: emberjs/rfcs#995
Supersedes: ember-cli/ember-resolver#971