Merged
Conversation
ember-cli-babel 8 uses a peerDep on @babel/core, which is why this also adds @babel/core explicitly. This is motivated by my work in the build-reform branch, which wants to rely on the static block support added in ember-cli-babel 8.2.
NullVoxPopuli
approved these changes
Apr 19, 2024
| "unlink:all": "node bin/unlink-all.mjs" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/core": "^7.24.4", |
Contributor
There was a problem hiding this comment.
Do we not need to forward the peer to consumers?
Contributor
Author
There was a problem hiding this comment.
That's a choice. We can either have it in dependencies or in peerDependencies. In dependencies is more conservative and non-breaking.
Contributor
Author
There was a problem hiding this comment.
(The path forward to getting rid of all this is when it's a v2 addon it won't try to bring any babel shenanigans at all.)
This was referenced Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-cli-babel 8 uses a peerDep on @babel/core, which is why this also adds @babel/core explicitly to dependencies.
This is motivated by my work in the build-reform branch, which wants to rely on the static block support added in ember-cli-babel 8.2.