[FEATURE] Add a --route-authoring-format option to the route generator#20835
Merged
kategengler merged 1 commit intoemberjs:mainfrom May 5, 2025
Merged
Conversation
Windvis
commented
Jan 23, 2025
Windvis
commented
Jan 23, 2025
Windvis
commented
Jan 23, 2025
Windvis
commented
Jan 23, 2025
14cad41 to
9a0a990
Compare
Contributor
|
I've added this to the agenda for us to discuss a name on tuesday. thanks for working on this!!! |
9a0a990 to
975bd95
Compare
--strict-template option to the route generator--strict-route-template option to the route generator
975bd95 to
770cc30
Compare
--strict-route-template option to the route generator--route-authoring-format option to the route generator
--route-authoring-format option to the route generator--route-authoring-format option to the route generator
--route-authoring-format option to the route generator--route-authoring-format option to the route generator
Windvis
commented
Mar 4, 2025
blueprints/route/files/__root__/__templatepath__/__templatename__.gts
Outdated
Show resolved
Hide resolved
Windvis
commented
Mar 14, 2025
kategengler
approved these changes
Apr 28, 2025
Member
|
I'm 👍 but this will need rebasing after #20862 lands |
Contributor
|
there are no conflicts -- why rebase? 🤔 |
Member
Contributor
Author
|
Yea, there are indeed conflicts, and there are also some other things I need to adjust (.gts tests, more types, ...). I need to find some time to look into it again. |
770cc30 to
379832d
Compare
Contributor
Development AssetsDiff Details
|
4fcdd2a to
93e5e9a
Compare
Windvis
commented
Apr 29, 2025
Comment on lines
+6
to
+7
| model: unknown; | ||
| controller: unknown; |
Contributor
Author
There was a problem hiding this comment.
I matched what the template-tag codemod outputs.
This allows users to generate .gjs/.gts templates instead of .hbs templates.
93e5e9a to
d38d1a7
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now that #20800 is merged, it would also be nice if we could generate new routes with a .gjs / .gts template already.
or the shorthand:
or as the project's default by adding
routeAuthoringFormat: 'strict'in .ember-cliCurrent status
Ready to review!