[Next] Kill Ember Array and Mixins#20921
Merged
wagenet merged 1 commit intoemberjs:nextfrom Jun 11, 2025
Merged
Conversation
7a9a08a to
d0d21f8
Compare
d0d21f8 to
4fc94e7
Compare
Contributor
Development AssetsDiff --- main/out.txt 2025-06-11 01:12:44.000000000 +0000
+++ pr/./pr-15596190164/out.txt 2025-06-11 21:34:28.000000000 +0000
@@ -1,35 +1,34 @@
2.2M └─┬ .
-996K ├─┬ @ember
-187K │ ├─┬ -internals
- 50K │ │ ├─┬ views
- 46K │ │ │ └─┬ lib
+930K ├─┬ @ember
+181K │ ├─┬ routing
+ 27K │ │ └── lib
+165K │ ├─┬ -internals
+ 44K │ │ ├─┬ views
+ 39K │ │ │ └─┬ lib
21K │ │ │ ├── system
- 10K │ │ │ ├── views
-5.6K │ │ │ ├── mixins
+9.1K │ │ │ ├── views
4.3K │ │ │ └── compat
- 35K │ │ ├─┬ runtime
- 30K │ │ │ └─┬ lib
- 21K │ │ │ ├── mixins
-5.7K │ │ │ └── ext
26K │ │ ├─┬ meta
21K │ │ │ └── lib
+ 20K │ │ ├─┬ runtime
+ 16K │ │ │ └─┬ lib
+6.4K │ │ │ ├── mixins
+5.7K │ │ │ └── ext
11K │ │ ├── owner
9.4K │ │ ├── deprecations
-7.4K │ │ ├── metal
+7.3K │ │ ├── metal
7.0K │ │ ├── string
5.0K │ │ ├── glimmer
-4.9K │ │ ├── utils
4.9K │ │ ├── routing
+4.8K │ │ ├── utils
4.5K │ │ ├── error-handling
4.5K │ │ ├── utility-types
4.2K │ │ ├── container
4.2K │ │ ├── browser-environment
4.1K │ │ └── environment
-183K │ ├─┬ routing
- 28K │ │ └── lib
-149K │ ├─┬ object
- 66K │ │ └─┬ lib
- 62K │ │ └── computed
+137K │ ├─┬ object
+ 63K │ │ └─┬ lib
+ 59K │ │ └── computed
114K │ ├─┬ template-compiler
109K │ │ └─┬ lib
20K │ │ ├── plugins
@@ -37,19 +36,19 @@
4.1K │ │ └── -internal
65K │ ├─┬ application
5.6K │ │ └── lib
- 52K │ ├─┬ debug
+ 51K │ ├─┬ debug
21K │ │ └── lib
- 38K │ ├─┬ array
-4.9K │ │ └── lib
- 31K │ ├─┬ engine
+ 30K │ ├─┬ engine
4.7K │ │ └── lib
- 27K │ ├── runloop
+ 26K │ ├── runloop
22K │ ├─┬ utils
- 18K │ │ └── lib
+ 17K │ │ └── lib
20K │ ├── helper
+ 11K │ ├─┬ array
+4.8K │ │ └── lib
11K │ ├── destroyable
9.8K │ ├── instrumentation
-9.4K │ ├── controller
+9.0K │ ├── controller
7.4K │ ├── service
7.2K │ ├── owner
6.2K │ ├── component
@@ -63,7 +62,7 @@
4.2K │ ├── deprecated-features
4.1K │ ├── template-factory
4.1K │ └── version
-722K ├── shared-chunks
+718K ├── shared-chunks
384K ├─┬ @glimmer
166K │ ├── runtime
60K │ ├── opcode-compiler
@@ -82,15 +81,16 @@
4.9K │ ├── encoder
4.6K │ ├── owner
4.1K │ └── env
- 60K ├─┬ ember-testing
- 55K │ └─┬ lib
+ 58K ├─┬ ember-testing
+ 54K │ └─┬ lib
14K │ ├── test
- 14K │ ├── helpers
+ 13K │ ├── helpers
10K │ ├── ext
6.4K │ └── adapters
31K ├── backburner.js
- 25K ├── ember
24K ├── route-recognizer
+ 23K ├── ember
+ 21K ├── tracked-built-ins
18K ├─┬ @simple-dom
14K │ └── document
9.2K ├── dag-mapDetails
|
4fc94e7 to
3807477
Compare
3807477 to
1fa44dc
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This kills the array mixin. It has some affect on routing which we have hacked around.
This should not be merged into main until
@ember/array,@ember/array/mutable, and the array computed macros have been deprecated.Additionally, we should carefully test the routing changes.