Draft
Conversation
8 tasks
Member
Author
|
I just realized that the approach of two mixins may not work with EDIT: A Proxy won't easily work either because we look for whether it's in a EDIT 2: I've reworked this and it should work as expected now. |
wagenet
force-pushed
the
deprecate-evented
branch
2 times, most recently
from
4a66206 to
6a955a2
Compare
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-02-17 19:37:18.000000000 +0000
+++ pr/./pr-22161890309/out.txt 2026-02-18 23:29:44.000000000 +0000
@@ -1,46 +1,46 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 351.99 KB │ 203.84 KB ║
+║ Total │ 357.48 KB │ 206.31 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.39 KB │ 181.91 KB ║
+║ Total │ 318.77 KB │ 184.35 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.65 KB │ 26.22 KB ║
-║ application │ 13.23 KB │ 8.05 KB ║
-║ array │ 13.01 KB │ 7.46 KB ║
+║ -internals │ 38.42 KB │ 27.26 KB ║
+║ application │ 13.35 KB │ 8.09 KB ║
+║ array │ 13.1 KB │ 7.55 KB ║
║ canary-features │ 304 B │ 389 B ║
-║ component │ 2.05 KB │ 1.64 KB ║
-║ controller │ 1.96 KB │ 1.41 KB ║
-║ debug │ 11.69 KB │ 8.12 KB ║
+║ component │ 2.05 KB │ 1.59 KB ║
+║ controller │ 2.01 KB │ 1.45 KB ║
+║ debug │ 11.77 KB │ 8.16 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 811 B ║
+║ helper │ 1.08 KB │ 814 B ║
║ instrumentation │ 2.43 KB │ 1.79 KB ║
-║ modifier │ 1.22 KB │ 965 B ║
-║ object │ 35.94 KB │ 22.16 KB ║
+║ modifier │ 1.22 KB │ 964 B ║
+║ object │ 38.38 KB │ 23.11 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 487 B ║
-║ routing │ 59.3 KB │ 34.12 KB ║
-║ runloop │ 2.36 KB │ 1.5 KB ║
-║ service │ 1 KB │ 845 B ║
-║ template │ 654 B │ 541 B ║
+║ renderer │ 630 B │ 478 B ║
+║ routing │ 60.03 KB │ 34.36 KB ║
+║ runloop │ 2.41 KB │ 1.52 KB ║
+║ service │ 1 KB │ 832 B ║
+║ template │ 654 B │ 523 B ║
║ template-compilation │ 429 B │ 366 B ║
║ template-compiler │ 123.08 KB │ 59.45 KB ║
║ template-factory │ 370 B │ 374 B ║
║ test │ 923 B │ 627 B ║
-║ utils │ 4.11 KB │ 3.6 KB ║
+║ utils │ 4.15 KB │ 3.65 KB ║
║ version │ 55 B │ 131 B ║
╚══════════════════════╧═══════════╧═══════════╝
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.6 KB │ 21.94 KB ║
+║ Total │ 38.71 KB │ 21.96 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable │ 2.77 KB │ 1.39 KB ║
║ encoder │ 81 B │ 171 B ║
@@ -53,7 +53,7 @@
║ program │ 252 B │ 301 B ║
║ reference │ 548 B │ 531 B ║
║ runtime │ 10.32 KB │ 5.32 KB ║
-║ tracking │ 1.34 KB │ 1.16 KB ║
+║ tracking │ 1.45 KB │ 1.19 KB ║
║ util │ 1.94 KB │ 1.68 KB ║
║ validator │ 15.75 KB │ 6.96 KB ║
║ vm │ 495 B │ 569 B ║Details
|
ef4
reviewed
Sep 5, 2025
Contributor
There was a problem hiding this comment.
Notes from RFC discussion: this file might have been unintentionally included.
- Add DEPRECATE_EVENTED to centralized deprecations registry - Consolidate all deprecation IDs to single 'ember-evented' ID - Switch all deprecate() calls to deprecateUntil() pattern - Update mixin deprecation infrastructure for DeprecationObject - Fix deprecation messages for consistency - Remove internal Evented copy from runtime package - Update all test files to use DEPRECATIONS.DEPRECATE_EVENTED.isEnabled - Revert unrelated barrel.ts onerror doc change Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
wagenet
force-pushed
the
deprecate-evented
branch
from
6a955a2 to
b9876d5
Compare
- Fix regex mismatch in each-test.js (/`on` is/ -> /`on()` event decorator/) - Add missing DEPRECATIONS.DEPRECATE_EVENTED.isEnabled argument - Fix 'actaully' typo in router-service.ts (3 instances) - Fix triple-asterisk JSDoc comment in mixin.ts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove unused expectDeprecation import and fix eslint-disable directives for duplicate class members. Apply prettier formatting to test files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Export mixin-deprecation utilities from @ember/-internals/utils - Update imports to use package exports instead of deep imports - Add type assertions for observer and listener methods - Restore function overloads for addListener/removeListener exports
- Add specific on() overload for route events to properly type transition callbacks - Change trigger() return type from any to boolean (matches sendEvent behavior) - Format observer.ts with prettier Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…DE_DEPRECATION_VERSION variants - Wrap EmberObject.extend(Evented).create() calls in expectDeprecation in events_test.js, since the mixin-level deprecation fires at class creation time - Add testUnless(DEPRECATIONS.DEPRECATE_EVENTED.isRemoved) guards to tests that use on(), Evented methods, or the on() event decorator, so they skip when the API is removed - Guard the 'each with array proxies' moduleFor with if (!isRemoved) since createList() uses on() and can't run at all when the API is removed at OVERRIDE_DEPRECATION_VERSION=15.0.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kategengler
reviewed
Feb 20, 2026
| DEPRECATE_EVENTED: deprecation({ | ||
| id: 'ember-evented', | ||
| for: 'ember-source', | ||
| since: { available: '6.12.0' }, |
Member
There was a problem hiding this comment.
Suggested change
| since: { available: '6.12.0' }, | |
| since: { available: '7.1.0' }, |
kategengler
reviewed
Feb 20, 2026
| If you really need the original behavior: | ||
|
|
||
| `import { getOnerror, setOnerror } from '@ember/-internals/error-handling';` | ||
| A function may be assigned to `Ember.onerror` to be called when Ember |
Member
There was a problem hiding this comment.
This reverts some docs changes
kategengler
reviewed
Feb 20, 2026
| # couple of the files. Once it is, we can switch this over to just ignoring | ||
| # `types/stable` entirely. | ||
| types/stable | ||
| .puppeteer-cache/ |
Member
There was a problem hiding this comment.
This was removed intentionally -- we no longer use puppeteer
Member
|
Do you think you could split this into a few PRs?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still need to figure out correct deprecation ids.
ember-learn/deprecation-app#1404