Deprecate template in favor of partial#3017
Merged
wagenet merged 1 commit intoemberjs:masterfrom Jul 28, 2013
Merged
Conversation
Also, don't emit a warning if you use the de-underscored template name with the `partial` helper. This is a step in the direction if simplifying all the different ways to insert a template.
Contributor
Author
|
Fixes #2242 |
Contributor
Author
|
Also more effectively closes the already closed #1930 |
Member
|
@wycats Does this seem ok to you? |
ghost
assigned
Member
|
Yep. |
wagenet
added a commit
that referenced
this pull request
Jul 28, 2013
Deprecate `template` in favor of `partial`
Member
|
@machty this spews some deprecation warnings mind cleaning these up? |
Contributor
Author
|
@stefanpenner I'm assuming these deprecation warnings spew when you use |
Member
|
We don't want extra noise in the ember-test suite itself, and now no longer does |
Contributor
Author
|
❤️ |
This was referenced Jul 30, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, don't emit a warning if you use the de-underscored
template name with the
partialhelper.This is a step in the direction if simplifying all the
different ways to insert a template.