[cleanup] ember-handlebars main.js Convert to single-quotes#9847
[cleanup] ember-handlebars main.js Convert to single-quotes#9847stefanpenner merged 1 commit intoemberjs:masterfrom
Conversation
Looks like double quotes is more common. We should add a style guide. |
|
Need to hold off on this until after #9827. |
|
@knownasilya To each their own. I try to use singe quoted strings like I would use symbols in Ruby, and double quoted to mean content. But I wouldn't put up a fight if it was part of a style guide. |
|
Either way using mixed quotes in the same file for the same thing is nuts (I generally follow the "single in JS and double in HTML/Handlebars" rule). |
That's exactly the problem 😉, and why a style guide is so necessary.
👍 |
|
@rwjblue I've been following basically that pattern, although anything in {{}} uses single-quote, but lately I've been moving away from that due to htmlbars landing, making hbs and html more closely tied together. |
|
#9849 👈 started an issue |
[cleanup] ember-handlebars main.js Convert to single-quotes
No description provided.