Skip to content

[cleanup] ember-handlebars main.js Convert to single-quotes#9847

Merged
stefanpenner merged 1 commit intoemberjs:masterfrom
knownasilya:handlebars-main-quotes
Dec 9, 2014
Merged

[cleanup] ember-handlebars main.js Convert to single-quotes#9847
stefanpenner merged 1 commit intoemberjs:masterfrom
knownasilya:handlebars-main-quotes

Conversation

@knownasilya
Copy link
Contributor

No description provided.

@knownasilya knownasilya changed the title [cleanup] ember-andlebars main.js Convert to single-quotes [cleanup] ember-handlebars main.js Convert to single-quotes Dec 9, 2014
@mmun
Copy link
Member

mmun commented Dec 9, 2014

~/Projects/ember.js/packages $ grep -r "from \"" . | wc -l
    2146
~/Projects/ember.js/packages $ grep -r "from \'" . | wc -l
     635

Looks like double quotes is more common. We should add a style guide.

@rwjblue
Copy link
Member

rwjblue commented Dec 9, 2014

Need to hold off on this until after #9827.

@knownasilya
Copy link
Contributor Author

@mmun we should totally do single-quotes, they are less cluttering, which is pretty important for a big project like ember. Also easier to type.

@rwjblue did you ever get jscs working? We can update that and jshint, and work on making the code cleaner.

@mmun
Copy link
Member

mmun commented Dec 9, 2014

@knownasilya To each their own. I try to use singe quoted strings like I would use symbols in Ruby, and double quoted to mean content. But I wouldn't put up a fight if it was part of a style guide.

@rwjblue
Copy link
Member

rwjblue commented Dec 9, 2014

Either way using mixed quotes in the same file for the same thing is nuts (I generally follow the "single in JS and double in HTML/Handlebars" rule).

@knownasilya
Copy link
Contributor Author

To each their own

That's exactly the problem 😉, and why a style guide is so necessary.

But I wouldn't put up a fight if it was part of a style guide.

👍

@knownasilya
Copy link
Contributor Author

@rwjblue I've been following basically that pattern, although anything in {{}} uses single-quote, but lately I've been moving away from that due to htmlbars landing, making hbs and html more closely tied together.

@knownasilya
Copy link
Contributor Author

#9849 👈 started an issue

stefanpenner added a commit that referenced this pull request Dec 9, 2014
[cleanup] ember-handlebars main.js Convert to single-quotes
@stefanpenner stefanpenner merged commit 0ae39b3 into emberjs:master Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants