Skip to content
This repository was archived by the owner on May 26, 2019. It is now read-only.

htmlsafe imports and links#2115

Merged
locks merged 3 commits intoemberjs:masterfrom
asizer:htmlsafe
Nov 6, 2017
Merged

htmlsafe imports and links#2115
locks merged 3 commits intoemberjs:masterfrom
asizer:htmlsafe

Conversation

@asizer
Copy link
Contributor

@asizer asizer commented Nov 6, 2017

htmlSafe is found in the @ember/string module, not the @ember/component module. Additionally, the link to the htmlSafe method was broken.

@locks
Copy link
Contributor

locks commented Nov 6, 2017

import { htmlSafe } from '@ember/string'; is deprecated as of ember-cli/ember-rfc176-data#38.

@asizer
Copy link
Contributor Author

asizer commented Nov 6, 2017

ugh, ok, but the current import { htmlSafe } from '@ember/component' doesn't exist and breaks the build at 2.16.2. Additionally, the htmlSafe link is broken in the docs right now, but the class does exist under the @ember/string module, so seems helpful to have a link to somewhere.

Took out the deprecated import statements and changed htmlSafe reference to Ember.String.htmlSafe, as the current import statement doesn't work.

@locks
Copy link
Contributor

locks commented Nov 6, 2017

Thanks for your contribution :)

@locks locks merged commit 8499488 into emberjs:master Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants