This repository was archived by the owner on May 26, 2019. It is now read-only.
Conversation
source/object-model/bindings.md
Outdated
Contributor
Author
There was a problem hiding this comment.
would it be more appropriate to say "between components and models"? or maybe we should just strike this sentence entirely - i'm not sure we need to say how great Ember is compared to other frameworks. thoughts?
Contributor
|
Small remarks aside, this looks good. |
Contributor
Author
|
Just updated this to remove references to Ember.Set, as it is deprecated. Fixes #558. |
michaelrkn
force-pushed
the
object-model
branch
from
b110f55 to
d4391f2
Compare
Contributor
Author
|
This should be good to go. @locks @HeroicEric any final thoughts? |
Contributor
|
💥 🔨 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: