Pre-RFC: Deprecate partials

[tomdale]

Partials are widely believed to be a bad idea, but we don't do enough to help people understand that they should always prefer a component to a partial.

We should deprecate partials in Ember, ideally as part of Octane. I believe the only thing blocking this currently is the lack of a deprecation RFC. We may also want a code mod that can automatically migrate the most common partial cases, although I'm not sure if I'd want to block deprecation on that.

[rwjblue]

We may also want a code mod that can automatically migrate the most common partial cases, although I'm not sure if I'd want to block deprecation on that.

I would like to see a codemod mentioned in the deprecation RFC, but I don't think we need to hold up work on implementing the deprecation for any codemod work...

[knownasilya]

Would https://github.com/dyfactor/dyfactor be the tool for that? I know it's still young, but I think it could handle all partial migrations if done right.

[ctcpip]

@lbeauvilliers it's happening

[lbeauvilliers]

@ctcpip 😱

I mean ... 🎉

[webark]

parsing the partial for all variables, and passing all those into a component seems like a harry task for a codemod..

[rwjblue]

You say hairy, I say fun 😜

[Alonski]

So just chiming in that after upgrading to Ember v3.7 I am seeing a regression related to Partials that is causing an error in my app.
I am all for deprecating partials!

[rwjblue]

@Alonski - You might want to report that over on emberjs/ember.js, we haven't intentionally broken anything related to partials...

[GavinJoyce]

Is there anything blocking the initial RFC from being created? If not, and it suits, I'd like to volunteer to author the RFC and then help implement the changes needed if it lands.

[rwjblue]

Nope, nothing blocking other than needing someone to work on it. 😸

[GavinJoyce]

👍 thanks, I'll draft an RFC soon