-
-
Notifications
You must be signed in to change notification settings - Fork 405
Closed
Description
This is specifically talking about calling "map/dictionary" objects as "hash", not about "hash location" in the router.
Problems:
hashis probably a Ruby-ism that we inherited, which makes little sense in our JS context- aside:
hashin ruby refers to the fact that it is implemented as a hash table, however, I believe the more common name for the abstract data type (i.e. decoupled from the implementation) is a map, dictionary or associative array..?
- aside:
- In JavaScript, it is probably more common to refer them to just as "objects" (the "o" in "POJOs")
- a
Mapis also a thing in modern JavaScript, but it's not what thehashhelper produces (maybe it should? probably not? unknown.)
- a
- A straw-man proposal is to rename the
hashhelper toobjorobject, and (maybe later?) deprecatehash- We should provide a codemod
- What should we call the second argument passed to helpers? The current signature is commonly referred to as "params and hash", and that's the name/identifier we generate for the function parameters in the blueprints. "options"? What about "params", do we want to rename that too?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels