rfc-1068 - Update the collections to be under the /collections path#1138
Merged
kategengler merged 2 commits intoadvance-rfc-1068from Aug 22, 2025
Merged
rfc-1068 - Update the collections to be under the /collections path#1138kategengler merged 2 commits intoadvance-rfc-1068from
kategengler merged 2 commits intoadvance-rfc-1068from
Conversation
11 tasks
kategengler
reviewed
Aug 17, 2025
| - "new TrackedWeakSet(" - [5 Results](https://github.com/search?q=%22new+TrackedWeakSet%28%22+NOT+is%3Afork++NOT+org%3Aemberjs+NOT+org%3Atracked-tools+NOT+org%3Aember-cli+NOT+org%3Aember-migration-utils+NOT+org%3Aember-learn+&type=code) | ||
| - "new TrackedWeakMap(" - [4 Results](https://github.com/search?q=%22new+TrackedWeakMap%28%22+NOT+is%3Afork++NOT+org%3Aemberjs+NOT+org%3Atracked-tools+NOT+org%3Aember-cli+NOT+org%3Aember-migration-utils+NOT+org%3Aember-learn+&type=code) | ||
|
|
||
| Additionally, specifying collections gives us a blessed path for exported other useful datastructures in the future without continually adding to the main export file (even though dead-code-elimination would eliminate what is unused - not importing what may not be used could help local development) |
Member
There was a problem hiding this comment.
Should it be @ember/reactive/data-structures?
Contributor
Author
There was a problem hiding this comment.
Maybe, but I didn't want to sound too computer sciency
Member
There was a problem hiding this comment.
😆 Maps,Sets,WeakMaps and WeakSets ... not at all computer science-y
Member
|
This seems a reasonable change as it has not yet been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to a separate RFC: #1137