Skip to content

Links and meta improvements#160

Closed
pangratz wants to merge 10 commits intoemberjs:masterfrom
pangratz:ember-data-links-meta-improvements
Closed

Links and meta improvements#160
pangratz wants to merge 10 commits intoemberjs:masterfrom
pangratz:ember-data-links-meta-improvements

Conversation

@pangratz
Copy link
Member

Rendered

cc @tchak @wecc


This RFC was born in Greece during the Ember Thalassa event, sponsored by bookingsync.com.

@pangratz pangratz added the T-ember-data RFCs that impact the ember-data library label Jul 29, 2016
@pangratz
Copy link
Member Author

pangratz commented Aug 7, 2016

I started working on a proof of concept https://github.com/pangratz/ember-data-meta-links-improvements.

- replace RecordArrayReference in favor of DocumentReference
- outline different locations of meta
- add code sample for different meta of a resource
- add unresolved question for additional `extractMeta` hook on
  `RESTSerializer`
@pangratz
Copy link
Member Author

pangratz commented Aug 13, 2016

I gave this more thought and after realizing that JSON-API allows different locations for meta on a JSON-API document (especially relevant for a single resource), I've updated this RFC:

  • replace RecordArrayReference in favor of DocumentReference
  • outline different locations of meta
  • add code sample for getting different meta of a resource
  • add unresolved question for additional extractMeta hook on RESTSerializer


Book.reopenClass({

didReceiveData(recordRef) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is very similar to the way we are handling this case in our hacked-up version of Ember Data we are currently using to address this problems. +1 to the approach from our POV.

@benkingcode
Copy link

Is there anything we can do to move this along? I can't use Ember Data until there's link-based relationship saving :(

@AKST
Copy link

AKST commented May 11, 2017

Same here, if there's any grunt work that first time contributor can do to help, I'd be happy to lend a hand

@kurko
Copy link

kurko commented May 11, 2017

summoning @wecc

@jvanantwerp
Copy link

For what it's worth, my company is in the same boat. Until Ember Data fully supports the JSONAPI spec, including using related links for operations other than GET, we can't recommend Ember's full scale use. We have data sets in the thousands so sending all the elements of a hasMany for simply deleting a single entry is not practical.

And we are willing to help and contribute as well.

@benkingcode
Copy link

This is a fundamental dealbreaker for Ember Data, and it's coming up on 2 years since I first ran into this issue. The roadblock doesn't seem to be in implementation but just having an RFC approved. Why can't we get a decision from the core team on this?

@lvjames
Copy link

lvjames commented Aug 22, 2017

Judging by the consensus here people are happy to wait indefinitely.

@benkingcode
Copy link

6 months further on, still no response from the core team. If there is some protocol or path to moving this forward that I'm not aware of, someone please inform me.

@benedikt-buchert
Copy link

FYI: #332

@benedikt-buchert
Copy link

FYI: #332

@runspired
Copy link
Contributor

@benedikt-d confirm that #332 supercedes this by solving the base set of cases. Closing.

@runspired runspired closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-ember-data RFCs that impact the ember-data library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants