Skip to content

Update and rename 0000-deprecate-route-render-methods.md to 0418-depr… #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
locks merged 1 commit into from
Dec 19, 2018
Merged

Update and rename 0000-deprecate-route-render-methods.md to 0418-depr… #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions text/0000-deprecate-route-render-methods.md → text/0418-deprecate-route-render-methods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
- Start Date: 2018-19-12
- RFC PR: (leave this empty)
- RFC PR: https://github.com/emberjs/rfcs/pull/418
- Ember Issue: (leave this empty)

# Summary
# Deprecate Route render APIs

## Summary

This RFC proposses the deprecation of [`Route#render`](https://emberjs.com/api/ember/3.6/classes/Route/methods/render?anchor=render), [`Route#renderTemplate`](https://emberjs.com/api/ember/3.6/classes/Route/methods/render?anchor=renderTemplate) and named `{{outlet}}` APIs.

# Motivation
## Motivation

These APIs are largely holdovers from a time where components where not as prominent in your typical Ember application. While they are still documented, these APIs created an interesting coupling between the `Route` and the template. These APIs are also prone to breaking conventional naming conventions, which can lead to confusion for developers.

# Transition Path
## Transition Path

The migration plan here is to just move to components for all the use cases you would use theses APIs for. For example, there was a time when you would do something like the following if you wanted to have a master-detail view for a shopping app.

Expand Down Expand Up @@ -54,19 +56,19 @@ Luckily, we can express this entire concept with components.

In the event you were using `model` to derive what to render, you can us the `{{component}}` helper to dynamically render a component.

# How We Teach This
## How We Teach This

This has not been a mainline API for quite some time now. The guides do not mention this functionality at all. It is likely that the majority of Ember applications do not use these APIs.

# Drawbacks
## Drawbacks

The drawback of this is we are saying that the `Route` and the route template of the same name are inherently coupled. In previous versions of Ember this didn't have to be so as long as you implemented `renderTemplate`.

# Alternatives
## Alternatives

No real alternatives.

# Unresolved questions
## Unresolved questions

Optional, but suggested for first drafts. What parts of the design are still
TBD?