Skip to content

Cleaning up small typos #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
locks merged 2 commits into from
Feb 15, 2019
Merged

Cleaning up small typos #447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7116a3
Cleaning up small typos
acorncom Feb 14, 2019
013a077
Merge branch 'strict-mode' into patch-1
acorncom Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions text/0000-handlebars-strict-mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ the [template imports RFC](./0000-template-imports.md)):
```hbs
---
import { eq, get, hash } from '@ember/template/helpers';
import { First, Second, Third } form './contextual-components';
import { First, Second, Third } from './contextual-components';
---

{{#if (eq this.selected "first")}}
Expand Down Expand Up @@ -208,7 +208,7 @@ The `precompile` function (a.k.a. [`precompileTemplate`](https://github.com/embe
is responsible for taking a template string, running AST plugins, checking for
errors and returning the "wire format" representation of the template. The
exact details of this "wire format" is unspecified and changes from time to
time across minor Ember versions. The only guarentee is that it returns a
time across minor Ember versions. The only guarantee is that it returns a
string whose content is a valid JavaScript expression.

For example:
Expand Down Expand Up @@ -417,7 +417,7 @@ implicit globals and dynamic resolution co-exist with template imports (the
primary consumer of the proposed strict mode). However, this will create a very
confusing compromise and users will not get most of the benefits of having
template imports in the first place. We will also lose out on the opportunity
to improve on the static guarentees in order to build better tools. Leaving
to improve on the static guarantees in order to build better tools. Leaving
around implicit globals also has the [issues](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md#relationship-with-globals)
discussed in the contextual helpers RFC.

Expand All @@ -438,7 +438,7 @@ discussed in the contextual helpers RFC.
2. Instead of proposing a standalone strict mode, we could just bundle these
semantics into the templates imports proposal.

That would make it a very long anc complex RFC. In addition, other build
That would make it a very long and complex RFC. In addition, other build
tools like [ember-cli-htmlbars-inline-precompile](https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile)
will not be able to adopt the same semantics.

Expand All @@ -451,15 +451,15 @@ discussed in the contextual helpers RFC.

We intend to move to an "attributes syntax always mean attributes" (and use
modifiers for the rare cases of setting properties). We briefly considered
groupping that change into the strict mode opt-in, but ultimately decided it
grouping that change into the strict mode opt-in, but ultimately decided it
would be too confusing for strict mode to include such a change. It's better
to deprecate the feature and make this an app-wide setting.

4. Fix `(action ...)` binding semantics in strict mode.

Similarly, there are some not ideal semantics issues with `(action ...)`
around how the function's `this` is bound. We similarly considered fixing it
in strict mode but ultimately decided it wouldn't be appropiate.
in strict mode but ultimately decided it wouldn't be appropriate.

## Unresolved questions

Expand Down