Skip to content

[DATA] Singleton RecordData#461

Merged
runspired merged 1 commit intoemberjs:masterfrom
runspired:ember-data-singleton-record-data
Jun 26, 2019
Merged

[DATA] Singleton RecordData#461
runspired merged 1 commit intoemberjs:masterfrom
runspired:ember-data-singleton-record-data

Conversation

@runspired
Copy link
Contributor

@runspired runspired commented Mar 7, 2019

@runspired runspired added T-ember-data RFCs that impact the ember-data library T-deprecation labels Mar 7, 2019
@runspired runspired changed the title Singleton RecordData [DATA] Singleton RecordData Mar 7, 2019
@igorT
Copy link
Member

igorT commented Mar 13, 2019

I think this is a great overall approach. Just a couple questions/suggestions:

What happens If you pass in an identifier that RD hasn't seen before to the methods?

Also, it might be helpful if you reiterated what the final RD interface looks like with these changes applied.

@hjdivad
Copy link
Member

hjdivad commented Jun 5, 2019

Per weekly discussion; action item to merge:

  1. the version issue listed inline
  2. drop the discussion of *Manager as it's an implementation detail and distracts from the public API

@igorT
Copy link
Member

igorT commented Jun 5, 2019

@igorT to look into isRecordInUse

@runspired runspired force-pushed the ember-data-singleton-record-data branch 3 times, most recently from e97cecc to 492075c Compare June 26, 2019 21:56
@runspired runspired merged commit 223be3e into emberjs:master Jun 26, 2019
@chriskrycho
Copy link
Contributor

Would someone please be so kind as update the Rendered link to point to the final location of the text? 🙏 Thanks!

@hjdivad
Copy link
Member

hjdivad commented Jul 16, 2019

updated; thanks @chriskrycho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Comment Period T-deprecation T-ember-data RFCs that impact the ember-data library

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants