Skip to content

fix some typos #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ef4 merged 1 commit into from
Jul 1, 2019
Merged

fix some typos #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions text/0000-embroider-v2-package-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ The Handlebars macros are:
- macroMaybeAttrs
- macroFailBuild

The difference in naming is because the JS macros get explicitly imported from `@ember/macros`, whereas the Handlebars macros do not, so they need an appropriate namespace prefix. (If we land template imports, I'm find with adjusting this RFC to make the names align.)
The difference in naming is because the JS macros get explicitly imported from `@ember/macros`, whereas the Handlebars macros do not, so they need an appropriate namespace prefix. (If we land template imports, I'm fine with adjusting this RFC to make the names align.)

### JavaScript Macro: importSync

Expand Down Expand Up @@ -487,7 +487,7 @@ export default implementation;
// ===============
// Or compile down to this if OwnConfig contains { useNewVersion: false }
let implementation
implementation = importSync("./new-component");
implementation = importSync("./old-component");
Copy link
Contributor

@ef4 ef4 Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not a bug, it's intentional to show that the output is different if the useNewVersion flag is false.

Copy link
Contributor

@ef4 ef4 Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, sorry, you're right, I had it backwards.

export default implementation;
```

Expand Down