Merged
Conversation
mixonic
force-pushed
the
helper-listing
branch
2 times, most recently
from
d727719 to
5b09e76
Compare
Merged
|
One place where this might not work is in component-integration tests. Unless the "boot time discovery" phase is run on constructing a container (rather than during an actual app boot), those integration tests won't be able to find helpers. |
Member
|
It will not require app boot. Component integration/unit tests are very much assisted by this RFC. |
|
|
2 tasks
Member
|
Implemented in emberjs/ember.js#11393. |
This was referenced Jun 11, 2015
mmun
added a commit
that referenced
this pull request
Jun 13, 2015
Helper listing (dashless helpers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered as HTML
A proposed solution for dashless helpers in 1.13. You should likely read #53 before this.