Update RFC section on inter-package dependencies#646
Merged
rwjblue merged 1 commit intoemberjs:explodefrom Jul 20, 2020
Merged
Conversation
Apply suggestions of emberjs#284 (comment)
ijlee2
approved these changes
Jul 20, 2020
Member
There was a problem hiding this comment.
Hi, @hakilebara. Thanks for updating the RFC and providing context.
I'm not familiar with the RFC, but based on @ef4's suggestion, your changes look good to me. I was wondering if there is someone in particular you would like to review your PR? (I don't have merge permissions in this repo so we'll need to find someone who can review as well.)
Author
|
Hi @ijlee2, I think any of the initial reviewers of the RFC would be good : ) |
Member
|
Seems good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply suggestions of #284 (comment)