Deprecate <LinkTo> Component Positional Arguments#698
Conversation
chancancode
force-pushed
the
deprecate-link-to-positional-args
branch
from
1934284 to
80dc688
Compare
chancancode
force-pushed
the
deprecate-link-to-positional-args
branch
from
80dc688 to
c9e48a9
Compare
snewcomer
left a comment
snewcomer
left a comment
There was a problem hiding this comment.
Excited for a day where positional args are removed from the framework! This is a great step.
| </LinkTo> | ||
| ``` | ||
|
|
||
| These migrations can be automated using the [angle brackets codemod](https://github.com/ember-codemods/ember-angle-brackets-codemod). |
| The `<LinkTo>` built-in component started life as a "helper" in the early days | ||
| of Ember, even before an official components API was created. Over time, it | ||
| became clear that `<LinkTo>` is better classified as a component than a helper | ||
| in modern Ember, and the learning materials have been updated accordingly. |
There was a problem hiding this comment.
https://guides.emberjs.com/release/routing/linking-between-routes/#toc_the-linkto--component
Do we want to reference any links for future readers or are they at risk to change?
There was a problem hiding this comment.
Thanks for including the link here so people reviewing the PR can find them. That said, there are also other places, such as the tutorial. This is meant to include all of these so I don't think we need to link from the RFC text itself.
chancancode
force-pushed
the
deprecate-link-to-positional-args
branch
from
c9e48a9 to
e7a1353
Compare
Hehe, I'm not so sure that this specifically will happen (helpers and modifiers will also use positional params still). |
|
Moving into final comment period. We will work on adding a nice ember-template-lint rule with a |
Co-authored-by: Matthew Beale <matt.beale@madhatted.com>
5 participants
Rendered