Skip to content

Clarify and amend import paths in RFC #496 and #671 #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwjblue merged 1 commit into from
Jan 8, 2021
Merged

Clarify and amend import paths in RFC #496 and #671 #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion text/0496-handlebars-strict-mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ On the other hand, the following built-in constructs will need to be imported
* `on` (`import { on } from '@ember/modifier'`)
* `Input` (`import { Input } from '@ember/component`)
* `LinkTo` (`import { LinkTo } from '@ember/routing`)
* `TextArea` (`import { TextArea } from '@ember/component'`)
* `Textarea` (`import { Textarea } from '@ember/component'`)

In general, built-ins that can be made importable should be imported. The main
difference are that some of the keywords uses internal language features (e.g.
Expand Down
12 changes: 12 additions & 0 deletions text/0671-modernize-built-in-components-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,18 @@ the built-in components on these legacy implementaitons, but custom subclasses
will continue to work. The deprecation message should provide information about
this legacy addon, or link to the deprecation details page that does.

Note that in accordance with [RFC #496](0496-handlebars-strict-mode.md), the
following import paths will be made available for use in strict mode:

* `Input` (`import { Input } from '@ember/component`)
* `LinkTo` (`import { LinkTo } from '@ember/routing`)
* `Textarea` (`import { Textarea } from '@ember/component'`)

However, unlike the deprecated import paths in group 1, these modules provide
opaque values that are intended for use in templates only. Since they do not
expose the implementation details of the built-in components, these new import
paths do not have the same issue described in this RFC.

The third and forth prevents globally modifiying the behavior of built-in
components. Users are encouraged to create wrapper components for use in their
apps or create custom subclasses using the legacy addon.
Expand Down