Amend RFC 0821: add Resolver public type#853
Merged
chriskrycho merged 4 commits intomasterfrom Nov 2, 2022
Merged
Conversation
chriskrycho
added
T-framework
wagenet
approved these changes
Sep 22, 2022
dfreeman
reviewed
Sep 28, 2022
Contributor
dfreeman
left a comment
dfreeman
left a comment
There was a problem hiding this comment.
A couple of questions, but more for my own edification than anything. I didn't know 3/5 of those hooks existed!
Contributor
Author
|
We talked about this at Framework Core today, and everybody agreed with @dfreeman's comments above (and my intuition): it really ought to be in |
Contributor
Author
|
Meant to merge this a few weeks ago! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed during the original work on 0821: Public API for Type-Only Imports, and caught while doing the work for emberjs/ember.js#20180. At last week’s Framework Core Team meeting, we agreed that it makes the most sense to add as an amendment to 821.
As a meta note, we expect to see this more often as we move to following RFC 0617: RFC Stages. 0821 is currently accepted and will become released once we finish implementing it.